Re: [PATCH v10 5/5] overlayfs: override_creds=off option bypass creator_cred

From: Mark Salyzyn
Date: Thu Jul 25 2019 - 14:07:20 EST


On 7/24/19 11:14 PM, Amir Goldstein wrote:
+void ovl_revert_creds(const struct cred *old_cred)
+{
+ if (old_cred)
+ revert_creds(old_cred);
+}
+
Mark,

Not sure if you have seen my "shutdown" patches:
https://lore.kernel.org/linux-fsdevel/20190715133839.9878-4-amir73il@xxxxxxxxx/

Good to know!


I am fine with this patch, but would like to request that you add @sb arg
to the ovl_revert_creds() helper, so it is more useful for other things in the
future that scope the underlying layers access (like shutdown).

Will respin and retest.

-- Mark