Re: [PATCH v4] platform/chrome: cros_ec_trace: update generating script

From: Enric Balletbo i Serra
Date: Thu Aug 01 2019 - 06:59:30 EST


Hi Tzung-Bi

On 30/7/19 16:07, Tzung-Bi Shih wrote:
> Hi Enric,
>
> I found it is error-prone to replace the EC_CMDS after updated.
> Perhaps, we should introduce an intermediate file "cros_ec_trace.inc".

I am not sure I get you here, a .inc? could you explain a bit more?

Thanks,
~ Enric

> The generating script replaces whole ".inc" file every time and the
> cros_ec_trace.c includes the "cros_ec_trace.inc".
>
> If this proposal makes sense to you, I can send the patch after this
> change landed for*-next.
>