Re: [PATCH v4 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

From: Christoph Hellwig
Date: Thu Aug 01 2019 - 12:35:01 EST


On Thu, Aug 01, 2019 at 11:19:06AM -0300, Jason Gunthorpe wrote:
> Sadly usnic does not use the core rdma umem abstraction but open codes
> an old version of it.
>
> In this version each sge in the sgl is exactly one page. See
> usnic_uiom_get_pages - so I think this loop is not a bug?

Actually, yes - I think we are fine given that we pass in the number
of elements. Thus merging by iommus won't affect the list.