Re: [PATCH v4 1/2] kernel.h: Update comment about simple_strto<foo>() functions

From: Andy Shevchenko
Date: Fri Aug 02 2019 - 03:56:05 EST


On Fri, Aug 2, 2019 at 4:47 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Thu, 2019-08-01 at 22:29 +0300, Andy Shevchenko wrote:

> > * Returns 0 on success, -ERANGE on overflow and -EINVAL on parsing error.
> > - * Used as a replacement for the obsolete simple_strtoull. Return code must
> > - * be checked.
> > + * Used as a replacement for the simple_strtoull. Return code must be checked.
>
> Using 'the' here is unnecessary and somewhat confusing.
>
> Perhaps:
>
> * Preferred over simple_strtoull() unless the end position is required
> * Return value must be checked

IIRC it simple returns back to the original comment.

--
With Best Regards,
Andy Shevchenko