Re: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build

[Philipp Zabel]

Hi Guido, Fabio,

On Fri, 2019-08-02 at 08:03 -0300, Fabio Estevam wrote:
> Hi Guido,
> 
> Good catch!
> 
> On Fri, Aug 2, 2019 at 7:55 AM Guido GÃnther <agx@xxxxxxxxxxx> wrote:
> > 
> > Since
> > 
> > commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
> > 
> > imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an
> 
> Actually, it is ipuv3-crtc.o that is built via imxdrm-objs, not
> imx-ipuv3-crtc.o.
> 
> Apart from that:
> 
> Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>

Thank you, applied to imx-drm/next with Fabio's R-b, and added Fixes:
tag, and the commit message changed as follows:

ÂÂÂÂdrm/imx: Drop unused imx-ipuv3-crtc.o build
ÂÂÂÂ
ÂÂÂÂSince
ÂÂÂÂ
ÂÂÂÂcommit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
ÂÂÂÂ
ÂÂÂÂthe former contents of imx-ipuv3-crtc.o are built via imxdrm-objs. So
ÂÂÂÂthere's no need to keep an extra entry with a non existing config value
ÂÂÂÂ(CONFIG_DRM_IMX_IPUV3).
ÂÂÂÂ
ÂÂÂÂFixes: 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
ÂÂÂÂSigned-off-by: Guido GÃnther <agx@xxxxxxxxxxx>
ÂÂÂÂReviewed-by: Fabio Estevam <festevam@xxxxxxxxx>
ÂÂÂÂSigned-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

no action necessary if you agree, otherwise just send a v2 and I'll
replace it.

regards
Philipp