On 2019-08-02 17:07:33, Roberto Sassu wrote:
Commit c78719203fc6 ("KEYS: trusted: allow trusted.ko to initialize w/o a^ if
TPM") allows the trusted module to be loaded even a TPM is not found to
avoid module dependency problems.
However, trusted module initialization can still fail if the TPM is
inactive or deactivated. This patch ignores tpm_get_random() errors in
init_digests() and returns -EFAULT in pcrlock() if the TPM didn't return
Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
The code changes look correct to me.
Reviewed-by: Tyler Hicks <tyhicks@xxxxxxxxxxxxx>
For whoever takes this patch through their tree, I think that adding the
following Fixes tag would be useful (as well as cc'ing stable):
Fixes: 240730437deb ("KEYS: trusted: explicitly use tpm_chip structure...")
I think it is also worth leaving a short note, in the commit message,
for backporters that commit 782779b60faa ("tpm: Actually fail on TPM
errors during "get random"") should be included with any backports of