Re: [RFC PATCH 2/3] mm, compaction: use MIN_COMPACT_COSTLY_PRIORITY everywhere for costly orders

From: Mike Kravetz
Date: Fri Aug 02 2019 - 13:44:26 EST

On 8/2/19 5:05 AM, Vlastimil Babka wrote:
> On 8/1/19 10:33 PM, Mike Kravetz wrote:
>> On 8/1/19 6:01 AM, Vlastimil Babka wrote:
>>> Could you try testing the patch below instead? It should hopefully
>>> eliminate the stalls. If it makes hugepage allocation give up too early,
>>> we'll know we have to involve __GFP_RETRY_MAYFAIL in allowing the
>>> MIN_COMPACT_PRIORITY priority. Thanks!
>> Thanks. This patch does eliminate the stalls I was seeing.
>> In my testing, there is little difference in how many hugetlb pages are
>> allocated. It does not appear to be giving up/failing too early. But,
>> this is only with __GFP_RETRY_MAYFAIL. The real concern would with THP
>> requests. Any suggestions on how to test that?
> Here's the full patch, can you include it in your series?

Yes. Thank you!

Mike Kravetz