Re: [PATCH v2 5/6] tpm: add driver for cr50 on SPI
From: Stephen Boyd
Date: Fri Aug 02 2019 - 18:32:53 EST
Quoting Jarkko Sakkinen (2019-08-02 13:43:18)
> On Thu, Jul 18, 2019 at 06:47:14PM +0200, Alexander Steffen wrote:
> > On 17.07.2019 21:57, Stephen Boyd wrote:
> > > Quoting Alexander Steffen (2019-07-17 05:00:06)
> > > > On 17.07.2019 00:45, Stephen Boyd wrote:
> > > > > From: Andrey Pronin <apronin@xxxxxxxxxxxx>
> > > > >
> > > > > +static unsigned short rng_quality = 1022;
> > > > > +module_param(rng_quality, ushort, 0644);
> > > > > +MODULE_PARM_DESC(rng_quality,
> > > > > + "Estimation of true entropy, in bits per 1024 bits.");
> > > >
> > > > What is the purpose of this parameter? None of the other TPM drivers
> > > > have it.
> > >
> > > I think the idea is to let users override the quality if they decide
> > > that they don't want to use the default value specified in the driver.
> > But isn't this something that applies to all TPMs, not only cr50? So
> > shouldn't this parameter be added to one of the global modules (tpm?
> > tpm_tis_core?) instead? Or do all low-level drivers (tpm_tis, tpm_tis_spi,
> > ...) need this parameter to provide a consistent interface for the user?
> This definitely something that is out of context of the patch set and
> thus must be removed from the patch set.
Ok. I've dropped this part of the patch.