Re: [PATCH] linux/bits.h: Add compile time sanity check of GENMASK inputs

[Masahiro Yamada]

On Sat, Aug 3, 2019 at 12:03 PM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:

>
> BTW, v2 is already inconsistent.
> If you wanted GENMASK_INPUT_CHECK() to return 'unsigned long',,
> you would have to cast (low) > (high) as well:
>
>                (unsigned long)((low) > (high)), UL(0))))
>
> This is totally redundant, and weird.

I take back this comment.
You added (unsigned long) to the beginning of this macro.
So, the type is consistent, but I believe all casts should be removed.


-- 
Best Regards
Masahiro Yamada