Re: [PATCH] arch/alpha: Remove dead code
From: Souptick Joarder
Date: Sat Aug 03 2019 - 15:44:30 EST
On Sun, Aug 4, 2019 at 12:50 AM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Sun, Aug 04, 2019 at 12:47:36AM +0530, Souptick Joarder wrote:
> > These are dead code since 2.6.11. If there is no plan to use
> > it further, this can be removed forever.
> What's the point in removing ifdefed-out debugging printks?
If those debugging printks are kept under "#if 0" purposefully, then those
can be left as it is. Other parts are under "if 0" can be removed as those are
not used since 2.6.11.
How about keeping those debugging printk under some CONFIG_*_DEBUG option ?
While browsing source code, I figure out there are huge amount of dead
'#if 0" and some of them are maintained since 2.6.* . I send few
similar patches for fbdev
driver and those are merged to linux-next.
But how about cleaning it in entire tree ( module wise) ? Does it make sense ?