Re: [PATCH] dma-direct: don't truncate dma_required_mask to bus addressing capabilities

From: Atish Patra
Date: Tue Aug 06 2019 - 16:16:51 EST


On Tue, 2019-08-06 at 07:23 +0200, Christoph Hellwig wrote:
> On Mon, Aug 05, 2019 at 05:51:53PM +0200, Lucas Stach wrote:
> > The dma required_mask needs to reflect the actual addressing
> > capabilities
> > needed to handle the whole system RAM. When truncated down to the
> > bus
> > addressing capabilities dma_addressing_limited() will incorrectly
> > signal
> > no limitations for devices which are restricted by the
> > bus_dma_mask.
> >
> > Fixes: b4ebe6063204 (dma-direct: implement complete bus_dma_mask
> > handling)
> > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>
> Yeah, this looks sensible. Atish, can you check if this helps on the
> HiFive board as well?

Yes. It fixes the nvme issue on HiFive Unleashed + Microsemi expansion
board.

FWIW,

Tested-by: Atish Patra <atish.patra@xxxxxxx>


Regards,
Atish