Re: [PATCH] loop: Add LOOP_SET_DIRECT_IO in compat ioctl

From: Joel Fernandes
Date: Tue Aug 06 2019 - 20:10:21 EST


On Tue, Aug 6, 2019 at 7:57 PM Alessio Balsini <balsini@xxxxxxxxxxx> wrote:
>
> Hi Joel,
>
> I was considering the rationale for this patch totally straightforward:
> it enables Direct I/O ioctl to 32 bit processes running on 64 bit
> systems for compatibility reasons, as for all the other lo_compat_ioctl
> commands.
> Also the reason why someone would decide to use Direct I/O with loop
> devices is well known, that is why the feature exists :) So I thought
> this was another redundant information to put in the commit message and
> decided to omit it.

No objections from me if maintainers are Ok with it.

> If you still think that I should update the commit message with this
> information, I will do so.

I think you should.

thanks,

- Joel