Re: [PATCH] soc: qcom: socinfo: Annotate switch cases with fall through

From: Bjorn Andersson
Date: Tue Aug 06 2019 - 22:18:45 EST


On Tue 06 Aug 18:50 PDT 2019, Stephen Rothwell wrote:

> Hi Bjorn,
>
> On Tue, 6 Aug 2019 18:24:57 -0700 Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote:
> >
> > qcom_socinfo->dbg_root,
> > &qcom_socinfo->info.raw_device_num);
> > + /* Fall through */
> > case SOCINFO_VERSION(0, 11):
> > + /* Fall through */
> > case SOCINFO_VERSION(0, 10):
> > + /* Fall through */
> > case SOCINFO_VERSION(0, 9):
>
> I don't think you need the comment between consecutive "case"s - just
> where there is actual code.
>

You're right, will respin the patch.

Thanks,
Bjorn