Re: linux-next: build failure after merge of the crypto tree

[Stephen Rothwell]

Hi all,

On Mon, 5 Aug 2019 14:57:36 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> Hi all,
> 
> After merging the crypto tree, today's linux-next build (sparc64
> defconfig) failed like this:
> 
> drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
> drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
>   err = devm_hwrng_register(&pdev->dev, &np->hwrng);
>                              ^~~~
>                              cdev
> drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in
> 
> Caused by commit
> 
>   3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> 
> I applied the following patch for today:
> 
> From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Date: Mon, 5 Aug 2019 14:49:59 +1000
> Subject: [PATCH] hwrng: fix typo in n2-drv.c
> 
> Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
> Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> ---
>  drivers/char/hw_random/n2-drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
> index 2d256b3470db..73e408146420 100644
> --- a/drivers/char/hw_random/n2-drv.c
> +++ b/drivers/char/hw_random/n2-drv.c
> @@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
>  	np->hwrng.data_read = n2rng_data_read;
>  	np->hwrng.priv = (unsigned long) np;
>  
> -	err = devm_hwrng_register(&pdev->dev, &np->hwrng);
> +	err = devm_hwrng_register(&op->dev, &np->hwrng);
>  	if (err)
>  		goto out_hvapi_unregister;
>  
> -- 
> 2.20.1

I am still applying that patch ...

-- 
Cheers,
Stephen Rothwell

Attachment: pgpWTEPoYg3cY.pgp
Description: OpenPGP digital signature