Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

From: Andrew Lunn
Date: Thu Aug 08 2019 - 15:40:55 EST


> @@ -568,6 +568,11 @@ int phy_start_aneg(struct phy_device *phydev)
> if (err < 0)
> goto out_unlock;
>
> + /* The PHY may not yet have cleared aneg-completed and link-up bit
> + * w/o this delay when the following read is done.
> + */
> + usleep_range(1000, 2000);
> +

Hi Heiner

Does 802.3 C22 say anything about this?

If this PHY is broken with respect to the standard, i would prefer the
workaround is in the PHY specific driver code, not generic core code.

Andrew