Re: [RFC PATCH v3 00/16] Core scheduling v3
From: Tim Chen
Date: Thu Aug 08 2019 - 17:43:07 EST
On 8/8/19 10:27 AM, Tim Chen wrote:
> On 8/7/19 11:47 PM, Aaron Lu wrote:
>> On Tue, Aug 06, 2019 at 02:19:57PM -0700, Tim Chen wrote:
>>> +void account_core_idletime(struct task_struct *p, u64 exec)
>>> + const struct cpumask *smt_mask;
>>> + struct rq *rq;
>>> + bool force_idle, refill;
>>> + int i, cpu;
>>> + rq = task_rq(p);
>>> + if (!sched_core_enabled(rq) || !p->core_cookie)
>>> + return;
>> I don't see why return here for untagged task. Untagged task can also
>> preempt tagged task and force a CPU thread enter idle state.
>> Untagged is just another tag to me, unless we want to allow untagged
>> task to coschedule with a tagged task.
> You are right. This needs to be fixed.
Here's the updated patchset, including Aaron's fix and also
added accounting of force idle time by deadline and rt tasks.