Re: cleanup the walk_page_range interface

From: Christoph Hellwig
Date: Thu Aug 08 2019 - 17:56:38 EST

On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote:
> > Note that both Thomas and Steven have series touching this area pending,
> > and there are a couple consumer in flux too - the hmm tree already
> > conflicts with this series, and I have potential dma changes on top of
> > the consumers in Thomas and Steven's series, so we'll probably need a
> > git tree similar to the hmm one to synchronize these updates.
> I'd be willing to just merge this now, if that helps. The conversion
> is mechanical, and my only slight worry would be that at least for my
> original patch I didn't build-test the (few) non-x86
> architecture-specific cases. But I did end up looking at them fairly
> closely (basically using some grep/sed scripts to see that the
> conversions I did matched the same patterns). And your changes look
> like obvious improvements too where any mistake would have been caught
> by the compiler.

I did cross compile the s390 and powerpc bits, but I do not have an
openrisc compiler.

> So I'm not all that worried from a functionality standpoint, and if
> this will help the next merge window, I'll happily pull now.

That would help with this series vs the others, but not with the other
series vs each other.