Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

From: Kees Cook
Date: Thu Aug 08 2019 - 19:09:09 EST


On Thu, Aug 08, 2019 at 03:33:00PM -0700, Andrew Morton wrote:
> On Thu, 8 Aug 2019 14:12:19 -0700 Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> > > The ones that are left are the mm ones: 4, 5, 6, 7 and 8.
> > >
> > > Andrew, could you take a look and give your Acked-by or pick them up directly?
> >
> > Given the subsystem Acks, it seems like 3-10 and 12 could all just go
> > via Andrew? I hope he agrees. :)
>
> I'll grab everything that has not yet appeared in linux-next. If more
> of these patches appear in linux-next I'll drop those as well.
>
> The review discussion against " [PATCH v19 02/15] arm64: Introduce
> prctl() options to control the tagged user addresses ABI" has petered
> out inconclusively. prctl() vs arch_prctl().

I've always disliked arch_prctl() existing at all. Given that tagging is
likely to be a multi-architectural feature, it seems like the controls
should live in prctl() to me.

--
Kees Cook