Re: [PATCH] net: tundra: tsi108: use spin_lock_irqsave instead of spin_lock_irq in IRQ context

From: David Miller
Date: Fri Aug 09 2019 - 01:17:10 EST


From: Fuqian Huang <huangfq.daxian@xxxxxxxxx>
Date: Wed, 7 Aug 2019 15:43:00 +0800

> @@ -372,8 +372,9 @@ static void tsi108_stat_carry(struct net_device *dev)
> {
> struct tsi108_prv_data *data = netdev_priv(dev);
> u32 carry1, carry2;
> + unsigned long flags;

Please preserve reverse christmas tree ordering of local variables.

Thank you.