Re: [PATCH v5] crypto: gcm - restrict assoclen for rfc4543

From: Herbert Xu
Date: Fri Aug 09 2019 - 02:20:10 EST


On Fri, Aug 02, 2019 at 11:47:33AM +0300, Iuliana Prodan wrote:
> Based on seqiv, IPsec ESP and rfc4543/rfc4106 the assoclen can be 16 or
> 20 bytes.
>
> >From esp4/esp6, assoclen is sizeof IP Header. This includes spi, seq_no
> and extended seq_no, that is 8 or 12 bytes.
> In seqiv, to asscolen is added the IV size (8 bytes).
> Therefore, the assoclen, for rfc4543, should be restricted to 16 or 20
> bytes, as for rfc4106.
>
> Signed-off-by: Iuliana Prodan <iuliana.prodan@xxxxxxx>
> Reviewed-by: Horia Geanta <horia.geanta@xxxxxxx>
> ---
> Changes since v4:
> - alignment.
> ---
> crypto/gcm.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt