Re: [PATCH] ext4: set error return correctly when ext4_htree_store_dirent fails

From: Theodore Y. Ts'o
Date: Mon Aug 12 2019 - 16:36:14 EST


On Mon, Aug 05, 2019 at 11:44:19PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently when the call to ext4_htree_store_dirent fails the error return
> variable 'ret' is is not being set to the error code and variable count is
> instead, hence the error code is not being returned. Fix this by assigning
> ret to the error return code.
>
> Addresses-Coverity: ("Unused value")
> Fixes: 8af0f0822797 ("ext4: fix readdir error in the case of inline_data+dir_index")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, thanks.

- Ted