Re: [PATCH] x86/cpu: Add Atom Tremont (Elkhart Lake)

From: Borislav Petkov
Date: Tue Aug 13 2019 - 03:20:51 EST


On Mon, Aug 12, 2019 at 09:43:38PM -0700, Kyung Min Park wrote:
> Add the Atom Tremont model number to the Intel family list.
>
> Signed-off-by: Kyung Min Park <kyung.min.park@xxxxxxxxx>
> ---
> arch/x86/include/asm/intel-family.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
> index 0278aa6..02d675d 100644
> --- a/arch/x86/include/asm/intel-family.h
> +++ b/arch/x86/include/asm/intel-family.h
> @@ -79,6 +79,7 @@
> #define INTEL_FAM6_ATOM_GOLDMONT_PLUS 0x7A /* Gemini Lake */
>
> #define INTEL_FAM6_ATOM_TREMONT_X 0x86 /* Jacobsville */
> +#define INTEL_FAM6_ATOM_TREMONT 0x96 /* Elkhart Lake */
>
> /* Xeon Phi */
>
> --

Did you have a look at this thread before sending this patch?

https://lkml.kernel.org/r/20190808101045.19239-1-rajneesh.bhardwaj@xxxxxxxxxxxxxxx

Either way, please do a second patch summing up the naming scheme
explanations. And send this patch adding the model number together with
its first user patchset.

Thx.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.