Re: [PATCH] sh: Drop -Werror from kernel Makefile

From: Yoshinori Sato
Date: Tue Aug 13 2019 - 04:49:38 EST


On Mon, 05 Aug 2019 11:14:23 +0900,
Guenter Roeck wrote:
>
> Since commit a035d552a93b ("Makefile: Globally enable fall-through
> warning"), all sh builds fail with errors such as
>
> arch/sh/kernel/disassemble.c: In function 'print_sh_insn':
> arch/sh/kernel/disassemble.c:478:8: error: this statement may fall through
>
> Since this effectively disables all build and boot tests for the
> architecture, let's drop -Werror from the sh kernel Makefile until
> the problems are fixed.
>
> Cc: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> arch/sh/kernel/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/sh/kernel/Makefile b/arch/sh/kernel/Makefile
> index 59673f8a3379..ef65f0625c6c 100644
> --- a/arch/sh/kernel/Makefile
> +++ b/arch/sh/kernel/Makefile
> @@ -47,5 +47,3 @@ obj-$(CONFIG_DWARF_UNWINDER) += dwarf.o
> obj-$(CONFIG_PERF_EVENTS) += perf_event.o perf_callchain.o
> obj-$(CONFIG_DMA_NONCOHERENT) += dma-coherent.o
> obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o
> -
> -ccflags-y := -Werror
> --
> 2.7.4
>

Applied sh-next.
Sorry too late replay.

--
Yosinori Sato