Re: [PATCH] net: ieee802154: remove redundant assignment to rc

From: Stefan Schmidt
Date: Tue Aug 13 2019 - 19:35:02 EST


Hello.

On 13.08.19 16:28, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Variable rc is initialized to a value that is never read and it is
> re-assigned later. The initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> net/ieee802154/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
> index dacbd58e1799..badc5cfe4dc6 100644
> --- a/net/ieee802154/socket.c
> +++ b/net/ieee802154/socket.c
> @@ -1092,7 +1092,7 @@ static struct packet_type ieee802154_packet_type = {
>
> static int __init af_ieee802154_init(void)
> {
> - int rc = -EINVAL;
> + int rc;
>
> rc = proto_register(&ieee802154_raw_prot, 1);
> if (rc)
>


This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt