RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

From: Parav Pandit
Date: Wed Aug 14 2019 - 01:31:03 EST


Hi Christoph, Greg,

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Tuesday, August 13, 2019 11:10 PM
> To: Christoph Hellwig <hch@xxxxxxxxxxxxx>; Parav Pandit
> <parav@xxxxxxxxxxxx>
> Cc: Kirti Wankhede <kwankhede@xxxxxxxxxx>; Alex Williamson
> <alex.williamson@xxxxxxxxxx>; kvm@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; cohuck@xxxxxxxxxx; cjia@xxxxxxxxxx
> Subject: Re: [PATCH v2 0/2] Simplify mtty driver and mdev core
>
> On Tue, Aug 13, 2019 at 09:37:21AM -0700, Christoph Hellwig wrote:
> > On Tue, Aug 13, 2019 at 02:40:02PM +0000, Parav Pandit wrote:
> > > We need to ask Greg or Linus on the kernel policy on whether an API should
> exist without in-kernel driver.
>
> I "love" it when people try to ask a question of me and they don't actually cc:
> me. That means they really do not want the answer (or they already know it...)
> Thanks Christoph for adding me here.
>
I pretty much knew your answer and I was just hinting Kirti that if you ask Greg you would get the same answer.
So we better cleanup without reaching out to you. :-)

> The policy is that the api should not exist at all, everyone knows this, why is this
> even a question?
>
Yes, I am aware of this. Few subsystems in which I worked, it has followed this policy cautiously.
But when I heard different policy for mdev, I asked others wisdom.

> > > We don't add such API in netdev, rdma and possibly other subsystem.
> > > Where can we find this mdev driver in-tree?
> >
> > The clear policy is that we don't keep such symbols around. Been
> > there done that only recently again.
>
> Agreed. If anyone knows of anything else that isn't being used, we will be glad
> to free up the space by cleaning it up.
>
Ok. so this small patchset makes sense.
Thanks for the ack and direction Christoph, Greg.