Re: [PATCH AUTOSEL 5.2 040/123] ASoC: Fail card instantiation if DAI format setup fails

From: Mark Brown
Date: Wed Aug 14 2019 - 05:22:18 EST


On Tue, Aug 13, 2019 at 10:09:24PM -0400, Sasha Levin wrote:
> From: Ricard Wanderlof <ricard.wanderlof@xxxxxxxx>
>
> [ Upstream commit 40aa5383e393d72f6aa3943a4e7b1aae25a1e43b ]
>
> If the DAI format setup fails, there is no valid communication format
> between CPU and CODEC, so fail card instantiation, rather than continue
> with a card that will most likely not function properly.

This is another one where if nobody noticed a problem already and things
just happened to be working this might break things, it's vanishingly
unlikely to fix anything that was broken.

Attachment: signature.asc
Description: PGP signature