Re: [PATCH 1/6] arm64: unexport set_memory_x and set_memory_nx

From: Will Deacon
Date: Wed Aug 14 2019 - 12:50:36 EST


On Tue, Aug 13, 2019 at 11:01:41AM +0200, Christoph Hellwig wrote:
> No module currently messed with clearing or setting the execute
> permission of kernel memory, and none really should.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> arch/arm64/mm/pageattr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
> index 03c53f16ee77..9ce7bd9d4d9c 100644
> --- a/arch/arm64/mm/pageattr.c
> +++ b/arch/arm64/mm/pageattr.c
> @@ -128,7 +128,6 @@ int set_memory_nx(unsigned long addr, int numpages)
> __pgprot(PTE_PXN),
> __pgprot(0));
> }
> -EXPORT_SYMBOL_GPL(set_memory_nx);
>
> int set_memory_x(unsigned long addr, int numpages)
> {
> @@ -136,7 +135,6 @@ int set_memory_x(unsigned long addr, int numpages)
> __pgprot(0),
> __pgprot(PTE_PXN));
> }
> -EXPORT_SYMBOL_GPL(set_memory_x);

arm64 allmodconfig and defconfig are happy with this, so I'll pick it up
for 5.4 if that's ok with you?

Will