Re: [PATCH 03/22] arm64: dts: qcom: sm8150: add tlmm node

From: Stephen Boyd
Date: Wed Aug 14 2019 - 13:01:07 EST


Quoting Vinod Koul (2019-08-14 05:49:53)
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> ---

Add some commit text? Or just squash with the first patch? Not sure why
it's a different commit.

> arch/arm64/boot/dts/qcom/sm8150.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index cd9fcadaeacb..5f2f21270e2d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -189,6 +189,21 @@
> };
> };
>
> + tlmm: pinctrl@3100000 {
> + compatible = "qcom,sm8150-pinctrl";
> + reg = <0x03100000 0x300000>,
> + <0x03500000 0x300000>,
> + <0x03900000 0x300000>,
> + <0x03D00000 0x300000>;

Please don't use capitalized hex characters.

> + reg-names = "west", "east", "north", "south";
> + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> + gpio-ranges = <&tlmm 0 0 175>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> +