RE: [EXT] Re: [v1 1/3] clk: ls1028a: Add clock driver for Display output interface

[Wen He]

> -----Original Message-----
> From: Stephen Boyd <sboyd@xxxxxxxxxx>
> Sent: 2019å8æ15æ 1:27
> To: linux-clk@xxxxxxxxxxxxxxx; linux-devel@xxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; liviu.dudau@xxxxxxx; Leo Li
> <leoyang.li@xxxxxxx>; Michael Turquette <mturquette@xxxxxxxxxxxx>; Wen
> He <wen.he_1@xxxxxxx>
> Subject: RE: [EXT] Re: [v1 1/3] clk: ls1028a: Add clock driver for Display output
> interface
> 
> 
> Quoting Wen He (2019-08-14 02:38:21)
> >
> >
> > > -----Original Message-----
> > > From: Stephen Boyd <sboyd@xxxxxxxxxx>
> > > Sent: 2019å8æ14æ 2:25
> > > To: Michael Turquette <mturquette@xxxxxxxxxxxx>; Wen He
> > > <wen.he_1@xxxxxxx>; Leo Li <leoyang.li@xxxxxxx>;
> > > linux-clk@xxxxxxxxxxxxxxx; linux-devel@xxxxxxxxxxxxxxxxxx;
> > > linux-kernel@xxxxxxxxxxxxxxx; liviu.dudau@xxxxxxx
> > > Cc: Wen He <wen.he_1@xxxxxxx>
> > > Subject: [EXT] Re: [v1 1/3] clk: ls1028a: Add clock driver for
> > > Display output interface
> > >
> > >
> > > Quoting Wen He (2019-08-12 03:01:03)
> > > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index
> > > > 801fa1cd0321..0e6c7027d637 100644
> > > > --- a/drivers/clk/Kconfig
> > > > +++ b/drivers/clk/Kconfig
> > > > @@ -223,6 +223,15 @@ config CLK_QORIQ
> > > >           This adds the clock driver support for Freescale QorIQ
> platforms
> > > >           using common clock framework.
> > > >
> > > > +config CLK_PLLDIG
> > > > +        bool "Clock driver for LS1028A Display output"
> > > > +        depends on ARCH_LAYERSCAPE && OF
> > >
> > > Does it actually depend on either of these to build? Probabl not, so
> > > maybe just default ARCH_LAYERSCAPE && OF? Also, can your Kconfig
> > > variable be named something more specific like CLK_LS1028A_PLLDIG?
> >
> > Actually it also depends Display modules, but we allow building
> > display drivers as modules, so is here whether need add Display
> > modules depend and also allow clock driver building to a module?
> > Would it be better to reduce the number of the modules insert, I think
> > the clock driver should be long available for the system.
> 
> I'm asking if it actually requires ARCH_LAYERSCAPE or OF to successfully
> compile the file. Is that true? I don't see any asm/ includes or anything that's
> going to fail if either of these configs aren't enabled.
> So it seems safe to change this to
> 
>         depends on ARCH_LAYERSCAPE || COMPILE_TEST
>         default ARCH_LAYERSCAPE
> 
> so that it's compiled by default on this architecture and is available to be
> compile tested by various test builders.

Understand, Will send next patch version.

Best Regards,
Wen

> 
> >
> > looks like great if named Kconfig variable to 'CLK_LS1028A_PLLDIG'.
> >
> > >