Re: [PATCH]Perf: Return error code for perf_session__new function on failure

From: Jiri Olsa
Date: Thu Aug 15 2019 - 08:51:15 EST


On Wed, Aug 14, 2019 at 03:02:18PM +0530, Mamatha Inamdar wrote:
> This Patch is to return error code of perf_new_session function
> on failure instead of NULL
> ----------------------------------------------
> Test Results:
>
> Before Fix:
>
> $ perf c2c report -input
> failed to open nput: No such file or directory
>
> $ echo $?
> 0
> ------------------------------------------
> After Fix:
>
> $ ./perf c2c report -input
> failed to open nput: No such file or directory
>
> $ echo $?
> 254
>
> Signed-off-by: Mamatha Inamdar <mamatha4@xxxxxxxxxxxxxxxxxx>
> Acked-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx>
> Reported-by: Nageswara R Sastry <rnsastry@xxxxxxxxxxxxxxxxxx>
> Tested-by: Nageswara R Sastry <rnsastry@xxxxxxxxxxxxxxxxxx>
> ---
> tools/perf/builtin-annotate.c | 5 +++--
> tools/perf/builtin-buildid-cache.c | 5 +++--
> tools/perf/builtin-buildid-list.c | 5 +++--
> tools/perf/builtin-c2c.c | 6 ++++--
> tools/perf/builtin-diff.c | 9 +++++----
> tools/perf/builtin-evlist.c | 5 +++--
> tools/perf/builtin-inject.c | 5 +++--
> tools/perf/builtin-kmem.c | 5 +++--
> tools/perf/builtin-kvm.c | 9 +++++----
> tools/perf/builtin-lock.c | 5 +++--
> tools/perf/builtin-mem.c | 5 +++--
> tools/perf/builtin-record.c | 5 +++--
> tools/perf/builtin-report.c | 4 ++--
> tools/perf/builtin-sched.c | 11 ++++++-----
> tools/perf/builtin-script.c | 9 +++++----
> tools/perf/builtin-stat.c | 11 ++++++-----
> tools/perf/builtin-timechart.c | 5 +++--
> tools/perf/builtin-top.c | 5 +++--
> tools/perf/builtin-trace.c | 4 ++--
> tools/perf/util/data-convert-bt.c | 4 +++-
> tools/perf/util/session.c | 13 +++++++++----
> 21 files changed, 80 insertions(+), 55 deletions(-)

I'm getting few conflicts, please rebase to latest Arnaldo's perf/core

patching file builtin-annotate.c
patching file builtin-buildid-cache.c
patching file builtin-buildid-list.c
patching file builtin-c2c.c
patching file builtin-diff.c
patching file builtin-evlist.c
patching file builtin-inject.c
patching file builtin-kmem.c
patching file builtin-kvm.c
patching file builtin-lock.c
patching file builtin-mem.c
patching file builtin-record.c
Hunk #2 succeeded at 1361 (offset 23 lines).
patching file builtin-report.c
patching file builtin-sched.c
patching file builtin-script.c
Hunk #1 FAILED at 48.
Hunk #2 succeeded at 3073 (offset 1 line).
Hunk #3 succeeded at 3743 (offset 1 line).
1 out of 3 hunks FAILED -- saving rejects to file builtin-script.c.rej
patching file builtin-stat.c
Hunk #1 succeeded at 81 with fuzz 1.
Hunk #2 succeeded at 1447 (offset 1 line).
Hunk #3 succeeded at 1646 (offset 1 line).
patching file builtin-timechart.c
patching file builtin-top.c
Hunk #1 succeeded at 74 (offset -1 lines).
Hunk #2 succeeded at 1668 (offset 25 lines).
patching file builtin-trace.c
Hunk #1 succeeded at 3573 (offset 320 lines).
patching file util/data-convert-bt.c
patching file util/session.c
Hunk #1 succeeded at 30 (offset 2 lines).
Hunk #2 succeeded at 184 (offset 2 lines).
Hunk #3 succeeded at 199 (offset 2 lines).
Hunk #4 succeeded at 222 (offset 2 lines).
Hunk #5 succeeded at 257 (offset 2 lines).

thanks,
jirka