Re: [PATCH 2/2] uacce: add uacce module

From: Greg Kroah-Hartman
Date: Thu Aug 15 2019 - 10:13:56 EST


On Wed, Aug 14, 2019 at 05:34:25PM +0800, Zhangfei Gao wrote:
> +int uacce_register(struct uacce *uacce)
> +{
> + int ret;
> +
> + if (!uacce->pdev) {
> + pr_debug("uacce parent device not set\n");
> + return -ENODEV;
> + }
> +
> + if (uacce->flags & UACCE_DEV_NOIOMMU) {
> + add_taint(TAINT_CRAP, LOCKDEP_STILL_OK);
> + dev_warn(uacce->pdev,
> + "Register to noiommu mode, which export kernel data to user space and may vulnerable to attack");
> + }

THat is odd, why even offer this feature then if it is a major issue?

thanks,

greg k-h