Re: [PATCH 6/6] driver core: initialize a default DMA mask for platform device

From: Geert Uytterhoeven
Date: Fri Aug 16 2019 - 03:39:17 EST

Hi Christoph,

On Fri, Aug 16, 2019 at 8:30 AM Christoph Hellwig <hch@xxxxxx> wrote:
> We still treat devices without a DMA mask as defaulting to 32-bits for
> both mask, but a few releases ago we've started warning about such
> cases, as they require special cases to work around this sloppyness.
> Add a dma_mask field to struct platform_device so that we can initialize
> the dma_mask pointer in struct device and initialize both masks to
> 32-bits by default, replacing similar functionality in m68k and
> powerpc. The arch_setup_pdev_archdata hooks is now unused and removed.
> Note that the code looks a little odd with the various conditionals
> because we have to support platform_device structures that are
> statically allocated.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> arch/m68k/kernel/dma.c | 9 -------

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

> arch/sh/boards/mach-ecovec24/setup.c | 2 --
> arch/sh/boards/mach-migor/setup.c | 1 -

Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
given "[PATCH 0/2] Remove calls to empty arch_setup_pdev_archdata()"



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds