Re: [Intel-gfx] [PATCH 2/5] kernel.h: Add non_block_start/end()

From: Jason Gunthorpe
Date: Fri Aug 16 2019 - 10:38:23 EST

On Fri, Aug 16, 2019 at 04:11:34PM +0200, Daniel Vetter wrote:
> Also, aside from this patch (which is prep for the next) and some
> simple reordering conflicts they're all independent. So if there's no
> way to paint this bikeshed here (technicolor perhaps?) then I'd like
> to get at least the others considered.

Sure, I think for conflict avoidance reasons I'm probably taking
mmu_notifier stuff via hmm.git, so:

- Andrew had a minor remark on #1, I am ambivalent and would take it
as-is. Your decision if you want to respin.
- #2/#3 is this issue, I would stand by the preempt_disable/etc path
Our situation matches yours, debug tests run lockdep/etc.
- #4 I like a lot, except the map should enclose range_end too,
this can be done after the mm_has_notifiers inside the
__mmu_notifier function
Can you respin?
I will propose preloading the map in another patch
- #5 is already applied in -rc