Re: [PATCH 2/2] clk: qcom: clk-rpmh: Add support for SM8150

From: Stephen Boyd
Date: Fri Aug 16 2019 - 12:58:16 EST


Quoting Vinod Koul (2019-08-15 21:24:40)
> On 14-08-19, 10:19, Stephen Boyd wrote:
> > Quoting Vinod Koul (2019-08-14 05:29:58)
> > > Add support for rpmh clocks found in SM8150
> > >
> > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > > ---
> >
> > Patch looks OK, but can you convert this driver to use the new parent
> > style and then update the binding to handle it? We can fix the other
> > platforms and dts files that use this driver in parallel, but sm8150
> > will be forward looking.
>
> Yes but that would also impact sdm845 as it uses this driver, so I
> wanted to get this one done so that we have support for rpm clock and
> then do the conversion.
>
> Would that be okay with you to get this in and then I convert this?
>

How does it impact sdm845? The new way of specifying parents supports
fallback to legacy string matching.