Re: [RFC PATCH v2 4/5] hugetlb_cgroup: Add accounting for shared mappings

From: Mina Almasry
Date: Fri Aug 16 2019 - 14:06:54 EST

On Fri, Aug 16, 2019 at 9:29 AM Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote:
> On 8/15/19 4:04 PM, Mina Almasry wrote:
> > On Wed, Aug 14, 2019 at 9:46 AM Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote:
> >>
> >> On 8/13/19 4:54 PM, Mike Kravetz wrote:
> >>> On 8/8/19 4:13 PM, Mina Almasry wrote:
> >>>> For shared mappings, the pointer to the hugetlb_cgroup to uncharge lives
> >>>> in the resv_map entries, in file_region->reservation_counter.
> >>>>
> >>>> When a file_region entry is added to the resv_map via region_add, we
> >>>> also charge the appropriate hugetlb_cgroup and put the pointer to that
> >>>> in file_region->reservation_counter. This is slightly delicate since we
> >>>> need to not modify the resv_map until we know that charging the
> >>>> reservation has succeeded. If charging doesn't succeed, we report the
> >>>> error to the caller, so that the kernel fails the reservation.
> >>>
> >>> I wish we did not need to modify these region_() routines as they are
> >>> already difficult to understand. However, I see no other way with the
> >>> desired semantics.
> >>>
> >>
> >> I suspect you have considered this, but what about using the return value
> >> from region_chg() in hugetlb_reserve_pages() to charge reservation limits?
> >> There is a VERY SMALL race where the value could be too large, but that
> >> can be checked and adjusted at region_add time as is done with normal
> >> accounting today.
> >
> > I have not actually until now; I didn't consider doing stuff with the
> > resv_map while not holding onto the resv_map->lock. I guess that's the
> > small race you're talking about. Seems fine to me, but I'm more
> > worried about hanging off the vma below.
> This race is already handled for other 'reservation like' things in
> hugetlb_reserve_pages. So, I don't think the race is much of an issue.
> >> If the question is, where would we store the information
> >> to uncharge?, then we can hang a structure off the vma. This would be
> >> similar to what is done for private mappings. In fact, I would suggest
> >> making them both use a new cgroup reserve structure hanging off the vma.
> >>
> >
> > I actually did consider hanging off the info to uncharge off the vma,
> > but I didn't for a couple of reasons:
> >
> > 1. region_del is called from hugetlb_unreserve_pages, and I don't have
> > access to the vma there. Maybe there is a way to query the proper vma
> > I don't know about?
> I am still thinking about closely tying cgroup revervation limits/usage
> to existing reservation accounting. Of most concern (to me) is handling
> shared mappings. Reservations created for shared mappings are more
> associated with the inode/file than individual mappings. For example,
> consider a task which mmaps(MAP_SHARED) a hugetlbfs file. At mmap time
> reservations are created based on the size of the mmap. Now, if the task
> unmaps and/or exits the reservations still exist as they are associated
> with the file rather than the mapping.

I'm aware of this behavior, and IMO it seems fine to me. I believe it
works the same way with tmfs today. I think a task that creates a file
in tmpfs gets charged the memory, and even if the task exits the
memory is still charged to its cgroup, and the memory remains charged
until the tmpfs file is deleted by someone.

Makes sense to me for hugetlb reservations to work the same way. The
memory remains charged until the hugetlbfs file gets deleted. But, if
you think of improvement, I'm happy to oblige :)

> Honesty, I think this existing reservation bevahior is wrong or at least
> not desirable. Because there are outstanding reservations, the number of
> reserved huge pages can not be used for other purposes. It is also very
> difficult for a user or admin to determine the source of the reservations.
> No one is currently complaining about this behavior. This proposal just
> made me think about it.
> Tying cgroup reservation limits/usage to existing reservation accounting
> will introduce the same issues there. We will need to clearly document the
> behavior.

Yes, seems we're maybe converging on a solution here, so the next
patchset will include docs for your review.

> > 2. hugetlb_reserve_pages seems to be able to conduct a reservation
> > with a NULL *vma. Not sure what to do in that case.
> >
> > Is there a way to get around these that I'm missing here?
> You are correct. The !vma case is there for System V shared memory such
> as a call to shmget(SHM_HUGETLB). In this case, reservations for the
> entire shared emmory segment are taken at shmget time.
> In your model, the caller of shmget who creates the shared memory segment
> would get charged for all the reservations. Users, (those calling shmat)
> would not be charged.
> > FWIW I think tracking is better in resv_map since the reservations are
> > in resv_map themselves. If I do another structure, then for each
> > reservation there will be an entry in resv_map and an entry in the new
> > structure and they need to be kept in sync and I need to handle errors
> > for when they get out of sync.
> I think you may be correct. However, this implies that we will need to
> change the way we do reservation in the resv_map for shared mappings.
> I will comment on that in reply to patch 4.
> --
> Mike Kravetz