Re: [PATCH 1/2] dt-bindings: amazon: add Amazon Annapurna Labs Alpine support

From: Rob Herring
Date: Fri Aug 16 2019 - 18:05:03 EST


On Sun, Jul 28, 2019 at 10:51:34PM +0300, Ronen Krupnik wrote:
> This patch adds DT bindings info for Amazon Annapurna Labs Alpine SOC
> and related reference boards.
>
> Signed-off-by: Ronen Krupnik <ronenk@xxxxxxxxxx>
> ---
> .../devicetree/bindings/arm/amazon,alpine.txt | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/amazon,alpine.txt

Board bindings are in DT schema format now.

Also, we already have al,alpine.yaml. Please combine with that one or
remove it perhaps. Seems kind of abandoned given the lack of response on
it.

>
> diff --git a/Documentation/devicetree/bindings/arm/amazon,alpine.txt b/Documentation/devicetree/bindings/arm/amazon,alpine.txt
> new file mode 100644
> index 000000000000..58817208421b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/amazon,alpine.txt
> @@ -0,0 +1,23 @@
> +Amazon Annapurna Labs Alpine v3 Platform Device Tree Bindings
> +---------------------------------------------------------------
> +
> +Platforms based on Amazon Annapurna Labs Alpine SoC architecture
> +shall follow the following scheme:
> +
> +SoCs
> +----
> +
> +Each device tree root node must specify which exact SoC in alpine
> +architecture it uses, using one of the following compatible values:
> +
> +- alpine v3
> + compatible = "amazon,alpine-v3";
> +
> +Boards
> +------
> +
> +Each device tree must specify which one or more of the following
> +board-specific compatible values:
> +
> +- alpine-v3 Evaluation Platform (EVP)
> + compatible = "amazon,alpine-v3-evp";
> --
> 2.21.0
>