Re: [PATCH 1/1] Fix: trace sched switch start/stop racy updates

From: Mathieu Desnoyers
Date: Fri Aug 16 2019 - 21:26:00 EST

----- On Aug 16, 2019, at 4:49 PM, rostedt rostedt@xxxxxxxxxxx wrote:

> On Fri, 16 Aug 2019 16:44:10 -0400
> Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote:
>> I am also more on the side of using *_ONCE. To me, by principal, I
>> would be willing to convert any concurrent plain access using _ONCE,
>> just so we don't have to worry about it now or in the future and also
>> documents the access.
>> Perhaps the commit message can be reworded to mention that the _ONCE
>> is an additional clean up for safe access.
> The most I'll take is two separate patches. One is going to be marked
> for stable as it fixes a real bug. The other is more for cosmetic or
> theoretical issues, that I will state clearly "NOT FOR STABLE", such
> that the autosel doesn't take them.

Splitting this into two separate patches makes perfect sense.



Mathieu Desnoyers
EfficiOS Inc.