Re: [PATCH v1 1/2] dt-binding: hwrng: add NPCM RNG documentation
From: Avi Fishman
Date: Sun Aug 18 2019 - 03:27:29 EST
On Tue, Aug 13, 2019 at 2:36 AM Rob Herring <robh@xxxxxxxxxx> wrote:
> On Mon, Jul 22, 2019 at 06:02:40PM +0300, Tomer Maimon wrote:
> > Added device tree binding documentation for Nuvoton BMC
> > NPCM Random Number Generator (RNG).
> > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
> > ---
> > .../bindings/rng/nuvoton,npcm-rng.txt | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt
> > diff --git a/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt
> > new file mode 100644
> > index 000000000000..a697b4425fb3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.txt
> > @@ -0,0 +1,17 @@
> > +NPCM SoC Random Number Generator
> > +
> > +Required properties:
> > +- compatible : "nuvoton,npcm750-rng" for the NPCM7XX BMC.
> > +- reg : Specifies physical base address and size of the registers.
> > +
> > +Optional property:
> > +- quality : estimated number of bits of true entropy per 1024 bits
> > + read from the rng.
> > + If this property is not defined, it defaults to 1000.
> This would need a vendor prefix, however, I think it should be implied
> by the compatible string. It is fixed per SoC, right?
Tomer is on vacation, so I answer instead:
This value is the same for all our SoC flavor that contains this RNG HW.