Re: [PATCH] erofs: move erofs out of staging

From: Theodore Y. Ts'o
Date: Sun Aug 18 2019 - 13:44:47 EST

On Sun, Aug 18, 2019 at 08:58:12AM -0700, Christoph Hellwig wrote:
> On Sun, Aug 18, 2019 at 11:11:54AM -0400, Theodore Y. Ts'o wrote:
> > Note that of the mainstream file systems, ext4 and xfs don't guarantee
> > that it's safe to blindly take maliciously provided file systems, such
> > as those provided by a untrusted container, and mount it on a file
> > system without problems. As I recall, one of the XFS developers
> > described file system fuzzing reports as a denial of service attack on
> > the developers.
> I think this greatly misrepresents the general attitute of the XFS
> developers. We take sanity checks for the modern v5 on disk format
> very series, and put a lot of effort into handling corrupted file
> systems as good as possible, although there are of course no guaranteeÑ.
> The quote that you've taken out of context is for the legacy v4 format
> that has no checksums and other integrity features.

Actually, what Prof. Kim's research group was doing was taking the
latest file system formats (for ext4 and xfs) and fixing up the
checksum after fuzzing the metadata blocks. The goal was to find
potential security vulnerabilities, not to see if file systems would
crash if fed invalid input. At least for ext4, at least one of
Prof. Kim's fuzzing results was one that that I believe could have
been leveraged into a stack overflow attack. I can't speak to his
results with respect to XFS, since I didn't look at them.


- Ted