Re: [PATCH] csky: Fixup ioremap function losing
From: Christoph Hellwig
Date: Sun Aug 18 2019 - 14:21:22 EST
On Sun, Aug 18, 2019 at 10:20:18AM +0800, Guo Ren wrote:
> > > Also change flag VM_ALLOC to VM_IOREMAP in get_vm_area_caller.
> > Looks generally fine, but two comments:
> > - do you have a need for ioremap_cache? We are generally try to
> > phase it out in favour of memremap, and it is generally only used
> > by arch specific code.
> Yes, some drivers of our customers use ioremap_cache to map phy_addr
> which isn't belong to system memory.
Which driver? We should move it over to memremap instead of adding
a new ioremap_cache.
> I agree to use GENERIC_IOREMAP, but I want to add csky support
> GENERIC_IOREMAP patch by myself.
> You could remove "csky: use generic ioremap" in your patchset first
> and I'll add support GENERIC_IORMAP patch later.
> Then we won't get confilct :)