Re: [RFC PATCH 00/15] acrn: add the ACRN driver module

From: Zhao, Yakui
Date: Sun Aug 18 2019 - 22:46:35 EST

On 2019å08æ16æ 15:03, Greg KH wrote:
On Fri, Aug 16, 2019 at 08:39:25AM +0200, Borislav Petkov wrote:
On Fri, Aug 16, 2019 at 10:25:41AM +0800, Zhao Yakui wrote:
The first three patches are the changes under x86/acrn, which adds the
required APIs for the driver and reports the X2APIC caps.
The remaining patches add the ACRN driver module, which accepts the ioctl
from user-space and then communicate with the low-level ACRN hypervisor
by using hypercall.

I have a problem with that: you're adding interfaces to arch/x86/ and
its users go into staging. Why? Why not directly put the driver where
it belongs, clean it up properly and submit it like everything else is

I don't want to have stuff in arch/x86/ which is used solely by code in
staging and the latter is lingering there indefinitely because no one is
cleaning it up...

I agree, stuff in drivers/staging/ must be self-contained, with no
changes outside of the code's subdirectory needed in order for it to
work. That way it is trivial for us to delete it when it never gets
cleaned up :)

Thanks for pointing out the rule of drivers/staging.
The acrn staging driver is one self-contained driver. But it has some dependency on arch/x86/acrn and need to call the APIs in arch/x86/acrn.

If there is no driver, the API without user had better not be added.
If API is not added, the driver can't be compiled correctly.
The ACRN driver is one new driver. Maybe it will have some bugs and not be mature. So we want to add the driver as the staging.

What is the better approach to handle such scenario?

You never say _why_ this should go into drivers/staging/, nor do you
have a TODO file like all other staging code that explains exactly what
needs to be done to get it out of there.

Ok. The TODO file will be added in next version.


greg k-h