Re: [PATCH] erofs: Use common kernel logging style

From: Joe Perches
Date: Mon Aug 19 2019 - 01:47:36 EST

On Mon, 2019-08-19 at 13:52 +0800, Gao Xiang wrote:
> Hi Joe,


> On Sun, Aug 18, 2019 at 10:28:41PM -0700, Joe Perches wrote:
> > Rename errln, infoln, and debugln to the typical pr_<level> uses
> > to the typical kernel styles of pr_<level>
> How about using erofs_err / ... to instead that?

<shrug> I've no opinion.
It seems most fs/*/* filesystems actually do use pr_<level>
sed works well if you want that.

> - I can hardly see directly use pr_<level> for those filesystems in fs/...

just fyi:

There was this one existing pr_<level> use in erofs

drivers/staging/erofs/data.c:366: pr_err("%s, readahead error at page %lu of nid %llu\n",
drivers/staging/erofs/data.c-367- __func__, page->index,
drivers/staging/erofs/data.c-368- EROFS_V(mapping->host)->nid);