Re: [PATCH 1/3] media: dt-bindings: Update bindings for Cadence CSI2RX version 2.1
From: Jan Kotas
Date: Mon Aug 19 2019 - 03:16:21 EST
> On 16 Aug 2019, at 23:18, Rob Herring <robh@xxxxxxxxxx> wrote:
> On Thu, Jul 25, 2019 at 11:26:46AM +0100, Jan Kotas wrote:
>> This patch adds a DT bindings documentation for
>> Cadence CSI2RX v2.1 controller.
> And 1.3?
OK, Iâll update the commit description.
>> Required properties:
>> - - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible
>> + - compatible: must be set to "cdns,csi2rx" or "cdns,csi2rx-1.3"
>> + for version 1.3 of the controller, "cdns,csi2rx-2.1" for v2.1
>> + and an SoC-specific compatible
> This wording is now not clear that an SoC-specific compatible is always
> required or just for 2.1. Please format one compatible per line.
OK, I will fix it in v2.
Thank you for the comments.