Re: [PATCH] ARM: dts: imx7d: cl-som-imx7: make ethernet work again
From: Shawn Guo
Date: Mon Aug 19 2019 - 03:51:37 EST
On Fri, Aug 09, 2019 at 04:12:27AM +0100, André Draszik wrote:
> Recent changes to the atheros at803x driver caused
> ethernet to stop working on this board.
> In particular commit 6d4cd041f0af
> ("net: phy: at803x: disable delay only for RGMII mode")
> and commit cd28d1d6e52e
> ("net: phy: at803x: Disable phy delay for RGMII mode")
> fix the AR8031 driver to configure the phy's (RX/TX)
> delays as per the 'phy-mode' in the device tree.
> This now prevents ethernet from working on this board.
> It used to work before those commits, because the
> AR8031 comes out of reset with RX delay enabled, and
> the at803x driver didn't touch the delay configuration
> at all when "rgmii" mode was selected, and because
> unconditionally enables TX delay.
> Since above commits ar8031_phy_fixup() also has no
> effect anymore, and the end-result is that all delays
> are disabled in the phy, no ethernet.
> Update the device tree to restore functionality.
> Signed-off-by: André Draszik <git@xxxxxxxxxx>
> CC: Ilya Ledvich <ilya@xxxxxxxxxxxxxx>
> CC: Igor Grinberg <grinberg@xxxxxxxxxxxxxx>
> CC: Rob Herring <robh+dt@xxxxxxxxxx>
> CC: Mark Rutland <mark.rutland@xxxxxxx>
> CC: Shawn Guo <shawnguo@xxxxxxxxxx>
> CC: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> CC: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> CC: Fabio Estevam <festevam@xxxxxxxxx>
> CC: NXP Linux Team <linux-imx@xxxxxxx>
> CC: devicetree@xxxxxxxxxxxxxxx
> CC: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx