Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"
From: Rafael J. Wysocki
Date: Mon Aug 19 2019 - 05:52:13 EST
On Thursday, August 15, 2019 12:47:35 AM CEST Dave Airlie wrote:
> On Thu, 15 Aug 2019 at 07:31, Karol Herbst <kherbst@xxxxxxxxxx> wrote:
> > This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c.
> > The original commit message didn't even make sense. AMD _does_ support it and
> > it works with Nouveau as well.
> > Also what was the issue being solved here? No references to any bugs and not
> > even explaining any issue at all isn't the way we do things.
> > And even if it means a muxed design, then the fix is to make it work inside the
> > driver, not adding some hacky workaround through ACPI tricks.
> > And what out of tree drivers do or do not support we don't care one bit anyway.
> I think the reverts should be merged via Rafael's tree as the original
> patches went in via there, and we should get them in asap.
> Acked-by: Dave Airlie <airlied@xxxxxxxxxx>
The _OSI strings are to be dropped when all of the needed support is there in
drivers, so they should go away along with the requisite driver changes.
I'm all for dropping then when that's the case, so please feel free to add ACKs
from me to the patches in question at that point.