Re: [Xen-devel] [PATCH 02/11] xen/arm: use dev_is_dma_coherent

From: Julien Grall
Date: Mon Aug 19 2019 - 07:31:20 EST

Hi Christoph,

On 8/16/19 2:00 PM, Christoph Hellwig wrote:
Use the dma-noncoherent dev_is_dma_coherent helper instead of the home
grown variant.

It took me a bit of time to understand that dev->archdata.dma_coherent and dev->dma_coherent will always contain the same value.

Would you mind it mention it in the commit message?

Other than that:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Signed-off-by: Christoph Hellwig <hch@xxxxxx>


Julien Grall