Re: [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API

From: Hans Verkuil
Date: Mon Aug 19 2019 - 10:55:43 EST


On 8/19/19 4:48 PM, Neil Armstrong wrote:
> Hi Dariusz, Hans,
>
> I can apply the dw-hdmi patches if necessary.

I'd appreciate it if you can do that.

Thanks,

Hans

>
> Neil
>
> On 19/08/2019 11:38, Hans Verkuil wrote:
>> Hi all,
>>
>> The patches in this series can be applied independently from each other.
>>
>> If you maintain one of these drivers and you want to merge it for v5.4
>> yourself, then please do so and let me know. If you prefer I commit it
>> to drm-misc, then please review and (hopefully) Ack the patch.
>>
>> I would really like to get this in for v5.4 so I can get the userspace
>> bits in for v5.4 as well through the media subsystem.
>>
>> Dariusz, can you post a v7.1 for patch 5/9 fixing the typo?
>>
>> Thanks!
>>
>> Hans
>>
>> On 8/14/19 12:44 PM, Dariusz Marcinkiewicz wrote:
>>> This series updates DRM drivers to use new CEC notifier API.
>>>
>>> Changes since v6:
>>> Made CEC notifiers' registration and de-registration symmetric
>>> in tda998x and dw-hdmi drivers. Also, accidentally dropped one
>>> patch in v6 (change to drm_dp_cec), brought it back now.
>>> Changes since v5:
>>> Fixed a warning about a missing comment for a new member of
>>> drm_dp_aux_cec struct. Sending to a wider audience,
>>> including maintainers of respective drivers.
>>> Changes since v4:
>>> Addressing review comments.
>>> Changes since v3:
>>> Updated adapter flags in dw-hdmi-cec.
>>> Changes since v2:
>>> Include all DRM patches from "cec: improve notifier support,
>>> add connector info connector info" series.
>>> Changes since v1:
>>> Those patches delay creation of notifiers until respective
>>> connectors are constructed. It seems that those patches, for a
>>> couple of drivers, by adding the delay, introduce a race between
>>> notifiers' creation and the IRQs handling threads - at least I
>>> don't see anything obvious in there that would explicitly forbid
>>> such races to occur. v2 adds a write barrier to make sure IRQ
>>> threads see the notifier once it is created (replacing the
>>> WRITE_ONCE I put in v1). The best thing to do here, I believe,
>>> would be not to have any synchronization and make sure that an IRQ
>>> only gets enabled after the notifier is created.
>>> Dariusz Marcinkiewicz (9):
>>> drm_dp_cec: add connector info support.
>>> drm/i915/intel_hdmi: use cec_notifier_conn_(un)register
>>> dw-hdmi-cec: use cec_notifier_cec_adap_(un)register
>>> tda9950: use cec_notifier_cec_adap_(un)register
>>> drm: tda998x: use cec_notifier_conn_(un)register
>>> drm: sti: use cec_notifier_conn_(un)register
>>> drm: tegra: use cec_notifier_conn_(un)register
>>> drm: dw-hdmi: use cec_notifier_conn_(un)register
>>> drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register
>>>
>>> .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 +++---
>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 46 +++++++++++++------
>>> drivers/gpu/drm/drm_dp_cec.c | 25 ++++++----
>>> drivers/gpu/drm/exynos/exynos_hdmi.c | 31 +++++++------
>>> drivers/gpu/drm/i2c/tda9950.c | 12 ++---
>>> drivers/gpu/drm/i2c/tda998x_drv.c | 36 ++++++++++-----
>>> drivers/gpu/drm/i915/display/intel_dp.c | 4 +-
>>> drivers/gpu/drm/i915/display/intel_hdmi.c | 13 ++++--
>>> drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +-
>>> drivers/gpu/drm/sti/sti_hdmi.c | 19 +++++---
>>> drivers/gpu/drm/tegra/output.c | 28 ++++++++---
>>> include/drm/drm_dp_helper.h | 17 ++++---
>>> 13 files changed, 155 insertions(+), 94 deletions(-)
>>>
>>
>