Re: [PATCH v8 10/28] x86/asm/entry: annotate interrupt symbols properly
From: Borislav Petkov
Date: Mon Aug 19 2019 - 10:56:56 EST
On Thu, Aug 08, 2019 at 12:38:36PM +0200, Jiri Slaby wrote:
> * annotate functions properly by SYM_CODE_START, SYM_CODE_START_LOCAL*
> and SYM_CODE_END -- these are not C-like functions, so we have to
> annotate them using CODE.
> * use SYM_INNER_LABEL* for labels being in the middle of other functions
> [v4] alignments preserved
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: <x86@xxxxxxxxxx>
> arch/x86/entry/entry_32.S | 28 ++++++++++++++--------------
> arch/x86/entry/entry_64.S | 13 ++++++-------
> 2 files changed, 20 insertions(+), 21 deletions(-)
Here again some of the symbols are used only in a single complilation
unit and thus made local symbols by prepending their name with ".L" so
that they don't pollute the symbol table. Pls do that for all symbols
you're touching, while you're at it.
Good mailing practices for 400: avoid top-posting and trim the reply.