Re: [PATCH v2] checkpatch: add *_NOTIFIER_HEAD as var definition

From: John Hubbard
Date: Mon Aug 19 2019 - 14:30:07 EST

On 8/19/19 5:29 AM, Gilad Ben-Yossef wrote:
Add *_NOTIFIER_HEAD as variable definition to avoid code like this:


From triggering the the following warning:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>
Cc: John Hubbard <jhubbard@xxxxxxxxxx>

Changes from v1:
- Fixed misposition of braces.
- Tested on 1k last commits from Linux tree.

Hi Gilad,

I re-ran this updated patch, on my local patches that were showing the problem,
and it is All Better Now. :) So you can add:

Tested-by: John Hubbard <jhubbard@xxxxxxxxxx>

John Hubbard

scripts/ | 1 +
1 file changed, 1 insertion(+)

diff --git a/scripts/ b/scripts/
index 93a7edfe0f05..8bc0e753a329 100755
--- a/scripts/
+++ b/scripts/
@@ -3864,6 +3864,7 @@ sub process {
+ ^.${Ident}_NOTIFIER_HEAD\(\Q$name\E\)|
)/x) {