Re: [PATCH v4 2/10] pwm: mediatek: droping the check for of_device_get_match_data

From: Uwe Kleine-König
Date: Tue Aug 20 2019 - 01:41:15 EST


On Tue, Aug 20, 2019 at 09:40:17AM +0800, Sam Shih wrote:
> From: sam shih <sam.shih@xxxxxxxxxxxx>

Your Signed-off-by and the mail's From uses capital letters. Can you
please make them all match?

> This patch drop the check for of_device_get_match_data.
> Due to the only way call driver probe is compatible match,
> In this case, the platform data should never be NULL.

Yeah, all entries in the of_match_table have a .data pointer.
Theoretically the driver could be bound by and then
of_device_get_match_data returns NULL.

It's still ok to drop this check if you want to, I just want to make
sure this possibility is known.

Best regards

Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | |